[Enhancement] boundary condition incorporation #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siuwuncheung
changed the title
liruipeng
reviewed
Oct 21, 2025
liruipeng
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Looks good to me modulo a few minor questions. Thanks @siuwuncheung
|
The PR looks good to me too. I only have a design question around the Chebyshev frequencies (see above). Another thing, which is beyond the scope of this PR, is that how do you guys think about using config files instead of relying on command line options to pass in values of various parameters? |
chakshinglee
approved these changes
Oct 24, 2025
|
Thanks for the review and changes @liruipeng @chakshinglee. I will merge this PR to main, and merge the changes from Rui Peng to #38 and resolve any conflicts. Then #38 is RFR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhance